-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubernetes startup probe #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wrighbr , can you please see to fix the EOL at EOF the CI is complaining about?
Otherwise this looks great to me and thanks for contributing this! 🙂 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Signed-off-by: Brett Wright <brett.wright@nine.com.au>
Co-authored-by: Vincenzo Scamporlino <me@vinzscam.dev> Signed-off-by: Brett Wright <brett.wright@nine.com.au>
Signed-off-by: Brett Wright <brett.wright@nine.com.au>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Description of the change
Adding kubernetes startup probe so users can configure startup probes as desired.
This is follow on work from #101
Existing or Associated Issue(s)
#138
Additional Information
Checklist
Chart.yaml
according to semver.values.yaml
and added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-run
to preview the content.ct lint
command.