Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubernetes startup probe #139

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Add kubernetes startup probe #139

merged 3 commits into from
Oct 20, 2023

Conversation

wrighbr
Copy link
Contributor

@wrighbr wrighbr commented Oct 3, 2023

Description of the change

Adding kubernetes startup probe so users can configure startup probes as desired.
This is follow on work from #101

Existing or Associated Issue(s)

#138

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@wrighbr wrighbr requested a review from a team as a code owner October 3, 2023 00:55
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wrighbr , can you please see to fix the EOL at EOF the CI is complaining about?

Otherwise this looks great to me and thanks for contributing this! 🙂 👍

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Brett Wright and others added 3 commits October 18, 2023 23:53
Signed-off-by: Brett Wright <brett.wright@nine.com.au>
Co-authored-by: Vincenzo Scamporlino <me@vinzscam.dev>
Signed-off-by: Brett Wright <brett.wright@nine.com.au>
Signed-off-by: Brett Wright <brett.wright@nine.com.au>
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@vinzscam vinzscam merged commit 4625407 into backstage:main Oct 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants